-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tooltip to navigation icons in sandbox #911
Conversation
@tuanphungcz is attempting to deploy a commit to the Blockstack Team on Vercel. A member of the Team first needs to authorize it. |
src/sandbox/components/side-nav.tsx
Outdated
@@ -5,7 +5,6 @@ import { ClarityIcon } from '@sandbox/components/clarity-icon'; | |||
import { Tooltip } from '@components/tooltip'; | |||
import FunctionIcon from 'mdi-react/FunctionIcon'; | |||
import { DropIcon } from '@components/icons/drop'; | |||
import { Routes } from '@sandbox/common/types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unused import
src/sandbox/components/side-nav.tsx
Outdated
</Grid> | ||
</Link> | ||
<Tooltip placement="left" label={nav.label}> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
< Tooltip />
tooltip round <Link />
doesn't render the tooltip, so I had to add the div.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@tuanphungcz Sorry for the delay -- can you resolve the merge conflict on this branch and rebase into a single commit, then I'll go ahead and merge? Thanks! |
743b077
to
23bcd18
Compare
@leahjlou Sure, I just rebased and resolved the conflict. |
🎉 This PR is included in version 1.59.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixes #851
Solution
added a tooltip to navigation icons in the sandbox
Demo
tooltip-sandbox.online-video-cutter.com.mp4